[web] [SIMS #254]Used symbols, updated components to use symbols #274
Conversation
2011sandeepraj
changed the title
| }, | ||
| setup(props: any) { | ||
| const router = useRouter(); | ||
| console.log("props"); |
There was a problem hiding this comment.
Please remove console logs.
| LOGIN: Symbol(), | ||
| STUDENTPROFILE: Symbol(), | ||
| STUDENTPROFILEEDIT: Symbol(), | ||
| FINANCIALAIDAPPLICATION: Symbol(), |
There was a problem hiding this comment.
Please consider using "_" to provide an easier reading.
| @@ -0,0 +1,17 @@ | |||
| export const routeConstants = { | |||
There was a problem hiding this comment.
I would recommend segregation between Students and Institutions routes. IMHO it would be easier to read and maintain.
It would be something like "routes.student.FINANCIAL_AID_APPLICATION" and "routes.institution.DASHBOARD".
| @@ -2,20 +2,27 @@ | |||
| <div class="p-component"> | |||
| <div class="p-card p-m-4"> | |||
| <Section title="Confirm Submission Page..." /> | |||
| <FooterNavigator previous="financial-info" /> | |||
| <FooterNavigator v-bind:previous="financialInfo" /> | |||
There was a problem hiding this comment.
Please condider use only the shortcut for v-bind (:previous="financialInfo") instead of (v-bind:previous="financialInfo").
There was a problem hiding this comment.
I just like using v-bind because it's more explicit. A little old school in this. Hope this is ok
sources/packages/web/src/views/student/financial-aid-application/ConfirmSubmission.vue
Outdated
Show resolved
Hide resolved
| @@ -93,13 +93,17 @@ | |||
| </ContentGroup> | |||
| </Section> | |||
| </ContentGroup> | |||
| <FooterNavigator previous="select-program" next="confirm-submission" /> | |||
| <FooterNavigator | |||
| v-bind:previous="selectProgram" | |||
There was a problem hiding this comment.
Please consider using the shortcut for v-bind (:previous) instead (v-bind:previous).
There was a problem hiding this comment.
I just like using v-bind because it's more explicit. A little old school in this. Hope this is ok
sources/packages/web/src/views/student/financial-aid-application/SelectProgram.vue
Outdated
Show resolved
Hide resolved
| @@ -4,7 +4,8 @@ module.exports = { | |||
| "^.+\\.vue$": "vue-jest", | |||
| }, | |||
| globals: { | |||
| "ts-jest": { | |||
| "ts-jest": { | |||
| babelConfig: 'babel.config.js', | |||
There was a problem hiding this comment.
Please adjust the double quotes to be aligned with the rest of the file.
| @@ -0,0 +1,17 @@ | |||
| export const routeConstants = { | |||
There was a problem hiding this comment.
Const object name should start with Capital letter.
**As a part of this PR, release v2.2.0 is merged to v2.3.0** --------- Co-authored-by: Bidyashish <[email protected]> Co-authored-by: Andrew Boni Signori <[email protected]>
**As a part of this PR, release v2.3.0 is merged to main. This PR contains the changes that were directly made into the release branch 2.2 and were updated to the release branch 2.3 when the release branch 2.2 was merged to 2.3** Co-authored-by: Bidyashish <[email protected]> Co-authored-by: Andrew Boni Signori <[email protected]>
Release 2.3 from intermediate branch. #4223 [- Student Bridge Match - PPD Status Not Importing ](ffb5aa5) --------- Co-authored-by: Shashank Shekhar <[email protected]> Co-authored-by: Andrew Boni Signori <[email protected]> Co-authored-by: Dheepak Ramanathan <[email protected]>
No description provided.